fix(component-sdk): gate component diagnostic logs#9
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces noisy component diagnostic output by gating console mirroring for component SDK progress events and logger info/debug output behind SENTRIS_DEBUG_COMPONENTS=1, while keeping structured trace/log collection and warn/error console behavior unchanged.
Changes:
- Add
shouldMirrorComponentDiagnostics()and guardconsole.log/console.debugmirroring for progress + info/debug logs. - Preserve warn/error console mirroring behavior.
- Add tests asserting progress + info/debug are not mirrored to the console by default.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/component-sdk/src/context.ts | Gates console mirroring for progress + info/debug behind SENTRIS_DEBUG_COMPONENTS=1. |
| packages/component-sdk/src/tests/context.test.ts | Adds coverage to ensure default behavior does not mirror to console for progress + info/debug. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
193
to
+197
| timestamp: new Date().toISOString(), | ||
| metadata, | ||
| }); | ||
| console.debug(`[${componentRef}]`, ...args); | ||
| if (shouldMirrorComponentDiagnostics()) { | ||
| console.debug(`[${componentRef}]`, ...args); |
Comment on lines
207
to
+211
| timestamp: new Date().toISOString(), | ||
| metadata, | ||
| }); | ||
| console.log(`[${componentRef}]`, ...args); | ||
| if (shouldMirrorComponentDiagnostics()) { | ||
| console.log(`[${componentRef}]`, ...args); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification